Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[QAA-399][Speculos] Move LLM/LLD Speculos common code #8741

Merged
merged 1 commit into from
Dec 23, 2024
Merged

[QAA-399][Speculos] Move LLM/LLD Speculos common code #8741

merged 1 commit into from
Dec 23, 2024

Conversation

abdurrahman-ledger
Copy link
Contributor

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • LLD E2E Tests

📝 Description

Move LLM/LLD Speculos common code
LLD Speculos run

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Dec 19, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 4:28pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Dec 19, 2024 4:28pm
native-ui-storybook ⬜️ Ignored (Inspect) Dec 19, 2024 4:28pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Dec 19, 2024 4:28pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD common Has changes in live-common labels Dec 19, 2024
@abdurrahman-ledger abdurrahman-ledger marked this pull request as ready for review December 19, 2024 17:08
@abdurrahman-ledger abdurrahman-ledger requested review from a team as code owners December 19, 2024 17:08
@abdurrahman-ledger abdurrahman-ledger merged commit 0db73a8 into develop Dec 23, 2024
62 of 64 checks passed
@abdurrahman-ledger abdurrahman-ledger deleted the support/qaa-399_speculos_common_code branch December 23, 2024 08:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bharamboure-ledger bharamboure-ledger bharamboure-ledger approved these changes

@ypolishchuk-ledger ypolishchuk-ledger ypolishchuk-ledger approved these changes

@LucasWerey LucasWerey LucasWerey approved these changes

Assignees

@abdurrahman-ledger abdurrahman-ledger

Labels
common Has changes in live-common desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@abdurrahman-ledger @LucasWerey @ypolishchuk-ledger @bharamboure-ledger